Fix reset dataset for 3d model update #1804
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1804 +/- ##
==========================================
+ Coverage 92.90% 93.06% +0.15%
==========================================
Files 121 121
Lines 17700 17700
==========================================
+ Hits 16444 16472 +28
+ Misses 1256 1228 -28
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This fixes resetting the dataSetId for 3d model updates.
Previously , trying to use ThreeDModelUpdate with a
data_set_id.set(None)would lead to a invalid request sent to 3d api.The dataSetId property is a "primitive" field, not an object, so the fix is to use the correct return type for it, CognitePrimitiveUpdate.
Checklist:
If a new method has been added it should be referenced in cognite.rst in order to generate docs based on its docstring.